go-i2p/gojava
1
0
Fork 0
mirror of https://github.com/go-i2p/gojava.git synced 2025-06-09 18:54:02 -04:00
Code Issues Packages Projects Releases Wiki Activity

Replace the generated jar atomically

Browse Source 
Fixes #8

This change creates a temporary file in the directory of the target jar.
The temporary file contains the generated jar and is atomically
renamed to the actual jar.

Thanks to @arfan for reporting this bug.
This commit is contained in:
sridharv
2018-01-17 16:30:54 +01:00
committed by Sridhar Venkatakrishnan
parent e3ed04cfbf
commit 891bb03169
1 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
gojava.go
View File

@ -218,12 +218,30 @@ func createJar(target, jarDir string) error {
if err := os.Chdir(cwd); err != nil {
return err
}
t, err := os.OpenFile(target, os.O_CREATE|os.O_RDWR, 0600)
if err != nil {
return err
dirName := filepath.Dir(target)
if _, err := os.Stat(dirName); err != nil && err == os.ErrNotExist {
if err = os.MkdirAll(dirName, 0644); err != nil {
return fmt.Errorf("failed to create: %v: %+v", dirName, err)
}
}
t, err := ioutil.TempFile(dirName, "."+filepath.Base(target)+".tmp")
if err != nil {
return fmt.Errorf("failed to create temporary file: %+v", err)
}
tempFileName := t.Name()
var successful bool
defer func() {
if successful {
return
}
if err := os.Remove(tempFileName); err != nil {
fmt.Fprintf(os.Stderr, "WARNING: failed to delete temporary file %s: %+v", tempFileName, err)
}
}()
w := zip.NewWriter(t)
verbosef("Building %s\n", target)
verbosef("Building %s\n", tempFileName)
if err := filepath.Walk(jarDir, func(path string, info os.FileInfo, walkErr error) error {
if walkErr != nil {
return walkErr
@ -257,6 +275,10 @@ func createJar(target, jarDir string) error {
if err := t.Close(); err != nil {
return err
}
if err := os.Rename(tempFileName, target); err != nil {
return fmt.Errorf("failed to atomically rename: %v", err)
}
successful = true
fmt.Printf("Finished building %s\n", target)
return nil
}