Update I2PAndroidHelper to recognise legacy release builds (e.g. for F-Droid) #49

Open
opened 2025-04-21 14:45:21 -04:00 by idk · 8 comments
Owner

Opened 5 years ago

Last modified 2 years ago

#1787assigneddefect

Update I2PAndroidHelper to recognise legacy release builds (e.g. for F-Droid)

Reported by:nextloopOwned by:Meeh
Priority:
major
Milestone:
0.9.42
Component:
apps/android
Version:
0.9.25
Keywords:

Cc:

Parent Tickets:

Sensitive:
no

Description

The App ID when building the legacy release is "net.i2p.android.router" which is missing in i2p.android.base/lib/helper/src/main/java/net/i2p/android/ui/I2PAndroidHelper.java.

Please add it. It brings up confusion for example when using lightning browser.

Subtickets

Opened [5 years ago](/timeline?from=2016-04-18T10%3A17%3A54Z&precision=second "See timeline at Apr 18, 2016 10:17:54 AM") Last modified [2 years ago](/timeline?from=2019-06-05T18%3A46%3A53Z&precision=second "See timeline at Jun 5, 2019 6:46:53 PM") ## [\#1787](/ticket/1787)[assigned](/query?status=assigned)[defect](/query?status=!closed&type=defect) # Update I2PAndroidHelper to recognise legacy release builds (e.g. for F-Droid) Reported by:[nextloop](/query?status=!closed&reporter=nextloop)Owned by:[Meeh](/query?status=!closed&owner=meeh) Priority: [major](/query?status=!closed&priority=major) Milestone: [0.9.42](/milestone/0.9.42 "Completed 20 months ago (Aug 27, 2019 12:00:00 PM)") Component: [apps/android](/query?status=!closed&component=apps%2Fandroid) Version: [0.9.25](/query?status=!closed&version=0.9.25) Keywords: Cc: Parent Tickets: Sensitive: [no](/query?status=!closed&sensitive=0) ### Description The App ID when building the legacy release is "net.i2p.android.router" which is missing in `i2p.android.base/lib/helper/src/main/java/net/i2p/android/ui/I2PAndroidHelper.java`. Please add it. It brings up confusion for example when using lightning browser. ### Subtickets
idk added this to the 0.9.42 milestone 2025-04-21 14:45:21 -04:00
idk added the
#1787
0.9.42
apps.android
labels 2025-04-21 14:45:21 -04:00
Author
Owner

@nextloop I don't know if this is still relevant can you advise?

@nextloop I don't know if this is still relevant can you advise?
Author
Owner

comment:7 Changed 2 years ago by zzz

Milestone:0.9.38 →
0.9.42Owner:
changed from str4d to _Meeh_Status:open →
assigned

[comment:7](https://trac.i2p2.de/\#comment:7) Changed [2 years ago](https://trac.i2p2.de//timeline?from=2019-06-05T18%3A46%3A53Z&precision=second "See timeline at Jun 5, 2019 6:46:53 PM") by zzz Milestone:0.9.38 → 0.9.42Owner: changed from _str4d_ to _Meeh_Status:open → assigned
Author
Owner

comment:6 Changed 2 years ago by zzz

Status:infoneeded →
open

no response, reassigning

[comment:6](https://trac.i2p2.de/\#comment:6) Changed [2 years ago](https://trac.i2p2.de//timeline?from=2019-06-05T18%3A46%3A30Z&precision=second "See timeline at Jun 5, 2019 6:46:30 PM") by zzz Status:infoneeded → open no response, reassigning
Author
Owner

comment:5 Changed 3 years ago by zzz

Milestone:0.9.26 →
0.9.38Status:reopened →
infoneeded

str4d please provide instructions on how to resolve this

[comment:5](https://trac.i2p2.de/\#comment:5) Changed [3 years ago](https://trac.i2p2.de//timeline?from=2018-09-28T15%3A48%3A36Z&precision=second "See timeline at Sep 28, 2018 3:48:36 PM") by zzz Milestone:0.9.26 → 0.9.38Status:reopened → infoneeded str4d please provide instructions on how to resolve this
Author
Owner

comment:4 Changed 4 years ago by nextloop

Resolution:fixedStatus:closed →
reopenedSummary:Update I2PAndroidHelper to recognise legacy release buildse (e.g. for F-Droid) →
Update I2PAndroidHelper to recognise legacy release builds (e.g. for F-Droid)

[comment:4](https://trac.i2p2.de/\#comment:4) Changed [4 years ago](https://trac.i2p2.de//timeline?from=2016-11-26T20%3A26%3A54Z&precision=second "See timeline at Nov 26, 2016 8:26:54 PM") by nextloop Resolution:fixedStatus:closed → reopenedSummary:Update I2PAndroidHelper to recognise legacy release buildse (e.g. for F-Droid) → Update I2PAndroidHelper to recognise legacy release builds (e.g. for F-Droid)
Author
Owner

comment:3 Changed 4 years ago by nextloop

Lightning browser redirects to F-Droid net.i2p.android now, which is the now disabled version.

[comment:3](https://trac.i2p2.de/\#comment:3) Changed [4 years ago](https://trac.i2p2.de//timeline?from=2016-11-26T20%3A26%3A30Z&precision=second "See timeline at Nov 26, 2016 8:26:30 PM") by nextloop Lightning browser redirects to F-Droid net.i2p.android now, which is the now disabled version.
Author
Owner

comment:2 Changed 5 years ago by str4d

Resolution:
→ fixedStatus:accepted →
closed

This was fixed in 9b8032380d1f779d0864017f22bda7e1e5e54730 and will be out in the upcoming 0.9 release of the client library.

[comment:2](https://trac.i2p2.de/\#comment:2) Changed [5 years ago](https://trac.i2p2.de//timeline?from=2016-06-13T08%3A45%3A11Z&precision=second "See timeline at Jun 13, 2016 8:45:11 AM") by str4d Resolution: → fixedStatus:accepted → closed This was fixed in `9b8032380d1f779d0864017f22bda7e1e5e54730` and will be out in the upcoming 0.9 release of the client library.
Author
Owner

comment:1 Changed 5 years ago by str4d

Status:new →
accepted

Wow, I don't know why URI_I2P_ANDROID_LEGACY got left as net.i2p.android.legacy when it should have been net.i2p.android.router from the start. I'll fix that and push out a new build of the client library.

[comment:1](https://trac.i2p2.de/\#comment:1) Changed [5 years ago](https://trac.i2p2.de//timeline?from=2016-04-18T10%3A50%3A30Z&precision=second "See timeline at Apr 18, 2016 10:50:30 AM") by str4d Status:new → accepted Wow, I don't know why `URI_I2P_ANDROID_LEGACY` got left as `net.i2p.android.legacy` when it should have been `net.i2p.android.router` from the start. I'll fix that and push out a new build of the client library.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: I2P_Developers/i2p.android.base#49
No description provided.