From 5a8b3eb8f34d048df9559deb8581e09c99e34267 Mon Sep 17 00:00:00 2001
From: zzz <zzz@mail.i2p>
Date: Fri, 13 Mar 2009 18:27:29 +0000
Subject: [PATCH] Move HMac to I2PHMac, as jrandom implemented changes that
 make it incompatible with the HMac in the android libraries.

---
 .../src/net/i2p/crypto/HMAC256Generator.java    |  9 +++++----
 core/java/src/net/i2p/crypto/HMACGenerator.java | 17 +++++++++--------
 .../crypto/macs/{HMac.java => I2PHMac.java}     | 10 +++++++---
 3 files changed, 21 insertions(+), 15 deletions(-)
 rename core/java/src/org/bouncycastle/crypto/macs/{HMac.java => I2PHMac.java} (95%)

diff --git a/core/java/src/net/i2p/crypto/HMAC256Generator.java b/core/java/src/net/i2p/crypto/HMAC256Generator.java
index 2fcaa7b5e..7d6f67a76 100644
--- a/core/java/src/net/i2p/crypto/HMAC256Generator.java
+++ b/core/java/src/net/i2p/crypto/HMAC256Generator.java
@@ -7,7 +7,8 @@ import net.i2p.data.Hash;
 import net.i2p.data.SessionKey;
 
 import org.bouncycastle.crypto.Digest;
-import org.bouncycastle.crypto.macs.HMac;
+import org.bouncycastle.crypto.Mac;
+import org.bouncycastle.crypto.macs.I2PHMac;
 
 /**
  * Calculate the HMAC-SHA256 of a key+message.  All the good stuff occurs
@@ -19,15 +20,15 @@ public class HMAC256Generator extends HMACGenerator {
     public HMAC256Generator(I2PAppContext context) { super(context); }
     
     @Override
-    protected HMac acquire() {
+    protected Mac acquire() {
         synchronized (_available) {
             if (_available.size() > 0)
-                return (HMac)_available.remove(0);
+                return (Mac)_available.remove(0);
         }
         // the HMAC is hardcoded to use SHA256 digest size
         // for backwards compatability.  next time we have a backwards
         // incompatible change, we should update this by removing ", 32"
-        return new HMac(new Sha256ForMAC());
+        return new I2PHMac(new Sha256ForMAC());
     }
     
     private class Sha256ForMAC extends Sha256Standalone implements Digest {
diff --git a/core/java/src/net/i2p/crypto/HMACGenerator.java b/core/java/src/net/i2p/crypto/HMACGenerator.java
index 8388590a2..52b29e19b 100644
--- a/core/java/src/net/i2p/crypto/HMACGenerator.java
+++ b/core/java/src/net/i2p/crypto/HMACGenerator.java
@@ -10,7 +10,8 @@ import net.i2p.data.Hash;
 import net.i2p.data.SessionKey;
 
 import org.bouncycastle.crypto.digests.MD5Digest;
-import org.bouncycastle.crypto.macs.HMac;
+import org.bouncycastle.crypto.Mac;
+import org.bouncycastle.crypto.macs.I2PHMac;
 
 /**
  * Calculate the HMAC-MD5 of a key+message.  All the good stuff occurs
@@ -49,7 +50,7 @@ public class HMACGenerator {
         if ((key == null) || (key.getData() == null) || (data == null))
             throw new NullPointerException("Null arguments for HMAC");
         
-        HMac mac = acquire();
+        Mac mac = acquire();
         mac.init(key.getData());
         mac.update(data, offset, length);
         //byte rv[] = new byte[Hash.HASH_LENGTH];
@@ -73,7 +74,7 @@ public class HMACGenerator {
         if ((key == null) || (key.getData() == null) || (curData == null))
             throw new NullPointerException("Null arguments for HMAC");
         
-        HMac mac = acquire();
+        Mac mac = acquire();
         mac.init(key.getData());
         mac.update(curData, curOffset, curLength);
         byte rv[] = acquireTmp();
@@ -86,17 +87,17 @@ public class HMACGenerator {
         return eq;
     }
     
-    protected HMac acquire() {
+    protected Mac acquire() {
         synchronized (_available) {
             if (_available.size() > 0)
-                return (HMac)_available.remove(0);
+                return (Mac)_available.remove(0);
         }
         // the HMAC is hardcoded to use SHA256 digest size
         // for backwards compatability.  next time we have a backwards
         // incompatible change, we should update this by removing ", 32"
-        return new HMac(new MD5Digest(), 32);
+        return new I2PHMac(new MD5Digest(), 32);
     }
-    private void release(HMac mac) {
+    private void release(Mac mac) {
         synchronized (_available) {
             if (_available.size() < 64)
                 _available.add(mac);
@@ -122,4 +123,4 @@ public class HMACGenerator {
                 _availableTmp.add((Object)tmp);
         }
     }
-}
\ No newline at end of file
+}
diff --git a/core/java/src/org/bouncycastle/crypto/macs/HMac.java b/core/java/src/org/bouncycastle/crypto/macs/I2PHMac.java
similarity index 95%
rename from core/java/src/org/bouncycastle/crypto/macs/HMac.java
rename to core/java/src/org/bouncycastle/crypto/macs/I2PHMac.java
index 7176c8aca..a566e8a79 100644
--- a/core/java/src/org/bouncycastle/crypto/macs/HMac.java
+++ b/core/java/src/org/bouncycastle/crypto/macs/I2PHMac.java
@@ -42,8 +42,12 @@ import org.bouncycastle.crypto.Mac;
  * a frequently used buffer (called on doFinal).  changes released into the public
  * domain in 2005.
  *
+ * This is renamed from HMac because the constructor HMac(digest, sz) does not exist
+ * in the standard bouncycastle library, thus it conflicts in JVMs that contain the
+ * standard library (Android).
+ *
  */
-public class HMac
+public class I2PHMac
 implements Mac
 {
     private final static int BLOCK_LENGTH = 64;
@@ -56,12 +60,12 @@ implements Mac
     private byte[] inputPad = new byte[BLOCK_LENGTH];
     private byte[] outputPad = new byte[BLOCK_LENGTH];
 
-    public HMac(
+    public I2PHMac(
         Digest digest)
     {
         this(digest, digest.getDigestSize()); 
     }
-    public HMac(
+    public I2PHMac(
         Digest digest, int sz)
     {
         this.digest = digest;